bump aws sdk v2 to v3 #2254

SylvainSenechal · 2025-08-12T13:53:09Z

bert-e · 2025-08-12T13:53:12Z

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-10-08T08:21:11Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

tests/zenko_tests/node_tests/VaultClient.js

Issue: ZENKO-5054

ISSUE: ZENKO-5054

DarkIsDude

Congrats for the work done. Not so easy to switch from callback to async/await and the code is clean and I didn't detect some logic issue. 👏

For eslint / or syntax I didn't add a comment on all places where is it, but if you fix one, check other occurences

tests/zenko_tests/node_tests/smoke_tests/vault_admin_and_IAM_API_tests/iamApi.js

tests/zenko_tests/node_tests/smoke_tests/vault_admin_and_IAM_API_tests/adminApi.js

tests/zenko_tests/node_tests/s3SDK.js

DarkIsDude · 2025-10-09T09:09:04Z

tests/zenko_tests/node_tests/init_test.js

+            { Bucket: bucket, Key: key },
+        ));
+        const chunks = [];
+        // eslint-disable-next-line no-restricted-syntax


Same here, a comment to explain why you don't follow our linter and/or change it to make it compliant with it 🙏

I would say this is not really useful, as the goal is to remove all these files and only use CTST

tests/zenko_tests/node_tests/backbeat/ReplicationUtility.js

tests/zenko_tests/node_tests/iam_policies/cloudserver/AssumeRole.js

tests/zenko_tests/node_tests/cloudserver/keyFormatVersion/tests/versioningSuspended.js

tests/zenko_tests/node_tests/VaultClient.js

bert-e · 2025-10-09T10:13:58Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following reviewers are expecting changes from the author, or must review again:

@DarkIsDude

tests/zenko_tests/node_tests/backbeat/LifecycleUtility.js

DarkIsDude · 2025-10-16T09:09:08Z

tests/zenko_tests/node_tests/backbeat/ReplicationUtility.js

-                }, () => cb(err));
+                })).then(() => cb(err)).catch(abortErr => {
+                    const aggregateError = new Error(`Original error: ${err}; Abort failed: ${abortErr}`);
+                    aggregateError.originalError = err;


Why we do that now ?

Mhh, just a way to keep track of both error, not the cleanest but also not super important as its a test.
Here, we keep track of both the error from completeMultiPartUpload, and the error from abortMultiPartUpload

tests/zenko_tests/node_tests/iam_policies/cloudserver/AssumeRole.js

tests/zenko_tests/node_tests/VaultClient.js

bert-e · 2025-10-16T09:23:26Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

williamlardier · 2025-10-16T12:46:33Z

tests/zenko_tests/node_tests/backbeat/tests/lifecycle/transition.js

        next => sourceClient.getObject(versionId, err => {
-            assert.strictEqual(err.code, 'InvalidObjectState');
-            assert.strictEqual(err.statusCode, 403);
+            const errorCode = err.Code || err.code;


Can't we know in advance what the code field will be? or is it to differentiate between different error types (but should be the same, as we use the same client?)

Actually I can, I'll clean this

ISSUE: ZENKO-5054

SylvainSenechal · 2025-10-17T07:56:06Z

/approve

bert-e · 2025-10-17T07:56:17Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.13

The following branches will NOT be impacted:

development/2.10
development/2.11
development/2.12
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2025-10-17T09:36:20Z

Queue build failed

The corresponding build for the queue failed:

Checkout the status page.
Identify the failing build and review the logs.
If no issue is found, re-run the build.
If an issue is identified, checkout the steps below to remove
the pull request from the queue for further analysis and maybe rebase/merge.

Remove the pull request from the queue

Add a /wait comment on this pull request.
Click on login on the status page.
Go into the manage page.
Find the option called Rebuild the queue and click on it.
Bert-E will loop again on all pull requests to put the valid ones
in the queue again, while skipping the one with the /wait comment.
Wait for the new queue to merge, then merge/rebase your pull request
with the latest changes to then work on a proper fix.
Once the issue is fixed, delete the /wait comment and
follow the usual process to merge the pull request.

bert-e · 2025-10-18T01:05:27Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.13

The following branches have NOT changed:

development/2.10
development/2.11
development/2.12
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue ZENKO-5054.

Goodbye sylvainsenechal.

SylvainSenechal force-pushed the improvement/ZENKO-5054 branch 29 times, most recently from d8b16cc to 6c6728b Compare August 14, 2025 15:54

SylvainSenechal force-pushed the improvement/ZENKO-5054 branch from fea7c95 to e60add3 Compare August 22, 2025 16:03

scality deleted a comment from bert-e Oct 8, 2025

SylvainSenechal force-pushed the improvement/ZENKO-5054 branch from e1dc391 to 9ba51a2 Compare October 8, 2025 08:34

SylvainSenechal commented Oct 8, 2025

View reviewed changes

tests/zenko_tests/node_tests/VaultClient.js Show resolved Hide resolved

SylvainSenechal force-pushed the improvement/ZENKO-5054 branch 2 times, most recently from bcdd21f to e791efe Compare October 8, 2025 16:14

SylvainSenechal added 2 commits October 9, 2025 10:34

bump zenko_tests from aws sdk v2 to v3

0ab5d6f

Issue: ZENKO-5054

bump ctst tests aws sdk to higher versions

0e5d500

ISSUE: ZENKO-5054

SylvainSenechal force-pushed the improvement/ZENKO-5054 branch from 667a273 to 54ba63d Compare October 9, 2025 08:40

SylvainSenechal marked this pull request as ready for review October 9, 2025 08:43

DarkIsDude requested changes Oct 9, 2025

View reviewed changes

SylvainSenechal force-pushed the improvement/ZENKO-5054 branch 2 times, most recently from 8ddae12 to 55f651a Compare October 16, 2025 08:57

DarkIsDude approved these changes Oct 16, 2025

View reviewed changes

williamlardier approved these changes Oct 16, 2025

View reviewed changes

SylvainSenechal added 5 commits October 16, 2025 19:04

migrate backbeat tests to aws sdk v3

c240fdd

ISSUE: ZENKO-5054

migrate cloudserver tests to aws sdk v3

66811cf

ISSUE: ZENKO-5054

migrate node_tests client to aws sdk v3

8844ee3

ISSUE: ZENKO-5054

migrate smoke_tests to aws sdk v3

f0fa325

ISSUE: ZENKO-5054

migrate iam_policies tests to aws sdk v3

ef5f304

ISSUE: ZENKO-5054

SylvainSenechal force-pushed the improvement/ZENKO-5054 branch from 55f651a to ef5f304 Compare October 16, 2025 17:04

bert-e merged commit 2d6914d into development/2.13 Oct 18, 2025
39 of 42 checks passed

bert-e deleted the improvement/ZENKO-5054 branch October 18, 2025 01:05

bump aws sdk v2 to v3 #2254

bump aws sdk v2 to v3 #2254

Uh oh!

Conversation

SylvainSenechal commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Aug 12, 2025

Hello sylvainsenechal,

Uh oh!

bert-e commented Oct 8, 2025

Waiting for approval

Uh oh!

Uh oh!

DarkIsDude left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DarkIsDude Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

DarkIsDude Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

williamlardier Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bert-e commented Oct 9, 2025

Waiting for approval

Uh oh!

Uh oh!

DarkIsDude Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bert-e commented Oct 16, 2025

Waiting for approval

Uh oh!

williamlardier Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal commented Oct 17, 2025

Uh oh!

bert-e commented Oct 17, 2025

In the queue

Uh oh!

bert-e commented Oct 17, 2025

Queue build failed

Uh oh!

bert-e commented Oct 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SylvainSenechal commented Aug 12, 2025 •

edited

Loading